Interactions: Fix broken UI on nested interactions #18499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5a7d04c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
2 tasks
ghengeveld
commented
Jun 17, 2022
| const nodes = value.slice(0, 3).map((v) => <Node key={v} value={v} nested />); | ||
| const nodes = value | ||
| .slice(0, 3) | ||
| .map((v) => <Node key={JSON.stringify(v)} value={v} nested callsById={callsById} />); |
There was a problem hiding this comment.
JSON.stringify is ugly but I think it's the simplest solution. I'm open to better suggestions.
|
This needs to be backported to 6.5 in order to make #18460 work, which also should be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here.
What I did
When using an array, any interactions within it were not receiving
callsById, which is required for some interactions to render properly. This PR fixes that and extends one of the stories to cover this scenario.I also fixed the
keyprop to not be an object.How to test
If your answer is yes to any of these, please make sure to include it in your PR.